Skip to content

Add oauth integration test#101

Merged
julien-nc merged 8 commits intomainfrom
enh/noid/oauth-tests
Mar 13, 2026
Merged

Add oauth integration test#101
julien-nc merged 8 commits intomainfrom
enh/noid/oauth-tests

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Mar 12, 2026

  • Add integration test going through the entire OAuth flow until getting a valid token
  • Update phpseclib to v3 and adjust to implementation
  • Use phpunit 11
  • Small refactoring here and there

This was done with some retro-engineering of the Discourse login flow and a lot of help from OpenCode+gpt-5.3-codex.

Remaining question: Do we opt for environment secrets + required reviewers (protection rule for the environment)? This can be annoying to manually review each action that uses a protected environment secret on each push to PRs.

@julien-nc julien-nc force-pushed the enh/noid/oauth-tests branch from aa5f8a9 to f2fd803 Compare March 12, 2026 13:50
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/oauth-tests branch from 25a7f40 to 0e09d8b Compare March 12, 2026 23:35
@julien-nc julien-nc marked this pull request as ready for review March 12, 2026 23:43
Copy link

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid, can't spot any major issues that prevents this from merge.

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@oleksandr-nc
Copy link

🚀🎉

@julien-nc julien-nc merged commit 908a6ea into main Mar 13, 2026
31 checks passed
@julien-nc julien-nc deleted the enh/noid/oauth-tests branch March 13, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants