[stable5.6] fix(imap): Add support for mail services that enforce a client id #12280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
requested review from
ChristophWurst and
kesselb
as code owners
Some mail services (e.g. mail163.com) do require an imap id to be given. Without further configuration sendID just sends NIL as ID. RFC: https://datatracker.ietf.org/doc/html/rfc2971 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Horde_Imap_Client_Base::sendID throws Horde_Imap_Client_Exception_NoSupportExtension when the ID capability is not advertised by the server. Since missing ID support is valid and expected IMAP behavior, we avoid using exceptions for control flow by checking the capability upfront. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
backport/12259/stable5.6
branch
from
ed9ac8f to
e5bfd72
Compare
ChristophWurst
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #12259 and #12318