feat: Add periodical job to clean outdated notifications#2897
Open
feat: Add periodical job to clean outdated notifications#2897
Conversation
Koc
force-pushed
the
feature/cleanup-outdated-notifications
branch
from
0eb8caa to
03d53d9
Compare
Koc
changed the title
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/cleanup-outdated-notifications
branch
from
03d53d9 to
94dca3c
Compare
Member
|
nickvergessen
requested changes
Apr 7, 2026
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
As mentioned at least the time constraint is not a good/acceptable one from my POV.
| ) | ||
| ->setMaxResults(1000) | ||
| ->executeQuery() | ||
| ->fetchAll(\PDO::FETCH_COLUMN); |
| continue; | ||
| } | ||
|
|
||
| $qb = $this->db->getQueryBuilder(); |
Member
There was a problem hiding this comment.
Should construct once and then only set the parameters for each call,
but this here will also not scale on bigger instances. We can't really have a background job that runs a query per user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our organization we have too many notificatons and this slowdowns app, increase db size, etc.
This PR adds possibility to cleanup outdated notifications that met next criteria:
I can move this hardcoded criterias to the settings if needed.