Skip to content

[stable33] fix: generate favourite icon without imagick svg support#58225

Open
backportbot[bot] wants to merge 1 commit into
stable33from
backport/55132/stable33
Open

[stable33] fix: generate favourite icon without imagick svg support#58225
backportbot[bot] wants to merge 1 commit into
stable33from
backport/55132/stable33

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Feb 10, 2026

Backport of PR #55132

@backportbot backportbot Bot requested review from a team and provokateurin as code owners February 10, 2026 15:19
@backportbot backportbot Bot requested review from Altahrim, ArtificialOwl, ChristophWurst, SebastianKrupinski, come-nc and salmart-dev and removed request for a team February 10, 2026 15:19
@backportbot backportbot Bot added bug 3. to review Waiting for reviews labels Feb 10, 2026
@backportbot backportbot Bot added this to the Nextcloud 33 milestone Feb 10, 2026
@SebastianKrupinski SebastianKrupinski marked this pull request as draft February 10, 2026 15:19
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review February 13, 2026 15:09
Comment on lines +147 to +149
$resX = (int)(72 * $size / $x);
$resY = (int)(72 * $size / $y);
$appIconFile->setResolution($resX, $resY);
Copy link
Copy Markdown
Contributor

@come-nc come-nc Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are reverting the fix I did in #57653
Please fix that in this backport and on master as well.

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the backport/55132/stable33 branch from 2590895 to 74d63b8 Compare May 11, 2026 20:02
@SebastianKrupinski
Copy link
Copy Markdown
Contributor

This will require this:

#58526

Then this:

#60234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants