feat: keep a classname mapping instead of always storing the full name for shares - #62904
Merged
Conversation
icewind1991
requested review from
Altahrim,
leftybournes,
nfebe and
salmart-dev
and removed request for
a team
August 4, 2026 19:42
icewind1991
changed the title
icewind1991
force-pushed
the
unified-sharing-classmap
branch
2 times, most recently
from
August 4, 2026 23:58
bf1ca51 to
3b135cf
Compare
CarlSchwan
approved these changes
Aug 5, 2026
CarlSchwan
reviewed
Aug 5, 2026
CarlSchwan
reviewed
Aug 5, 2026
susnux
reviewed
Aug 6, 2026
icewind1991
force-pushed
the
unified-sharing-classmap
branch
4 times, most recently
from
August 7, 2026 19:52
400b31f to
a86efd3
Compare
Member
Author
|
not sure why the test are failing consistently, but only on php 8.3 can't reproduce locally |
icewind1991
force-pushed
the
unified-sharing-classmap
branch
from
August 7, 2026 20:38
a86efd3 to
85af83f
Compare
Member
Author
was caused by cleanup not flushing cache, not sure why 8.5 didn't hit that though 🙉 |
icewind1991
force-pushed
the
unified-sharing-classmap
branch
2 times, most recently
from
August 7, 2026 20:52
f9907b0 to
2e21b7f
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # lib/private/Sharing/SharingBackend.php # lib/private/Sharing/SharingManager.php
…n existing shares Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-sharing-classmap
branch
from
August 8, 2026 11:06
2e21b7f to
4b8139a
Compare
susnux
approved these changes
Aug 8, 2026
CarlSchwan
enabled auto-merge
August 8, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of storing the full class name every time, keep a table that maps them to integers, so we only need to store an int.
Saves 60 bytes for each sharing source, recipient, property and permission
Extracted from #62708
Checklist
3. to review, feature component)stable32)AI (if applicable)