fix(files): keep reactivity when destructuring the store in grid view - #63188
Open
ELHart05 wants to merge 3 commits into
Open
fix(files): keep reactivity when destructuring the store in grid view#63188ELHart05 wants to merge 3 commits into
ELHart05 wants to merge 3 commits into
Conversation
ELHart05
requested review from
kristian-zendato and
susnux
and removed request for
a team
August 12, 2026 16:03
FileEntryGrid destructured useActiveStore() directly, so activeFolder, activeNode and activeView were plain snapshots taken when the entry was first rendered. Opening a file from grid view therefore handed the file actions a stale folder, and the viewer navigated the list to whichever folder happened to be active back then: from a nested folder this drops you at the root, or a level or two above, with the file open on top. Same fix as nextcloud#59942, which covered FileEntry but left its grid counterpart behind despite the "keep in sync with FileEntry.vue" note above it. Signed-off-by: ELHart05 <o.allaoua@esi-sba.dz>
ELHart05
force-pushed
the
fix/grid-entry-store-reactivity
branch
from
August 12, 2026 16:11
9c3e503 to
208428a
Compare
Signed-off-by: ELHart05 <o.allaoua@esi-sba.dz>
susnux
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#59942 fixed
FileEntry.vuebut leftFileEntryGrid.vuebehind, so the same bug is still there in grid view on 34.The grid entry destructures the store directly:
Those are plain values captured on the first render and never update again.
FileEntryMixin.execDefaultActionhandsthis.activeFolderto the file action, the viewer builds its route fromfolder.path, and the list gets navigated to whichever folder was active back then.Reproduced on 34.0.2 with the list in grid view, going into
/Level1/Level2/Level3/Level4and clicking a PDF:The first replace goes to
dir=/, so the root is fetched and the file opens over the wrong listing. It corrects itself a moment later, but the wrong navigation has already happened, and that is the "dropped back at the root" from #59941. The same steps in list view keep the right dir the whole way.Same
storeToRefschange as #59942. The setup block already carried a// keep in sync with FileEntry.vuecomment, which is what got missed.FileEntryGrid.spec.tscovers it: it fails on master and passes with the change.Worth backporting to stable34 and stable33, both are affected. Happy to request that once this looks good.
Checklist
3. to review, feature component)stable32)