Skip to content

fix(deps): update okhttp monorepo to v5 (major) #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(deps): update okhttp monorepo to v5 (major) #5123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab249ba
fix(deps): update okhttp monorepo to v5
renovate[bot] Mar 16, 2026
088d734
fix: remove server.start() now part of server.url() with okhttp5
AndyScherzinger Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ val daggerVersion = "2.59.2"
val emojiVersion = "1.6.0"
val fidoVersion = "4.1.0-patch2"
val lifecycleVersion = "2.10.0"
val okhttpVersion = "4.12.0"
val okhttpVersion = "5.3.2"
val markwonVersion = "4.6.2"
val materialDialogsVersion = "3.3.0"
val parcelerVersion = "1.1.13"
Expand Down
6 changes: 0 additions & 6 deletions app/src/test/java/com/nextcloud/talk/login/data/network/NetworkLoginDataSourceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class NetworkLoginDataSourceTest {
@Test
fun `testing anonymouslyPostLoginRequest correct path`() {
val server = MockWebServer()
server.start(0)
val httpUrl = server.url("index.php/login/v2")
val validResponse = """
{
Expand All @@ -60,7 +59,6 @@ class NetworkLoginDataSourceTest {
.setResponseCode(404)
.setBody("{}")

server.start()
server.enqueue(invalidResponse)
val httpUrl = server.url("index.php/login/v2")

Expand All @@ -82,7 +80,6 @@ class NetworkLoginDataSourceTest {

val mockResponse = MockResponse().setBody(validResponse)
server.enqueue(mockResponse)
server.start()
val httpUrl = server.url("index.php/login/v2")

val loginResponse = network.anonymouslyPostLoginRequest(httpUrl.toString())
Expand All @@ -104,7 +101,6 @@ class NetworkLoginDataSourceTest {
.setBody(validBody)

server.enqueue(validResponse)
server.start()
val httpUrl = server.url("login/v2/poll")
val loginResponse = LoginResponse(
token = "mQUYQdffOSAMJYtm8pVpkOsVqXt5hglnuSpO5EMbgJMNEPFGaiDe8OUjvrJ2WcYcBSLgqynu9jaPFvZHMl83ybMvp6aDIDARjTFIBpRWod6p32fL9LIpIStvc6k8Wrs1",
Expand All @@ -127,7 +123,6 @@ class NetworkLoginDataSourceTest {
.setBody("{}")

server.enqueue(invalidResponse)
server.start()
val httpUrl = server.url("login/v2/poll")
val loginResponse = LoginResponse(
token = "mQUYQdffOSAMJYtm8pVpkOsVqXt5hglnuSpO5EMbgJMNEPFGaiDe8OUjvrJ2WcYcBSLgqynu9jaPFvZHMl83ybMvp6aDIDARjTFIBpRWod6p32fL9LIpIStvc6k8Wrs1",
Expand All @@ -153,7 +148,6 @@ class NetworkLoginDataSourceTest {
.setBody(validBody)

server.enqueue(validResponse)
server.start()
val httpUrl = server.url("login/v2/poll")
val loginResponse = LoginResponse(
token = "mQUYQdffOSAMJYtm8pVpkOsVqXt5hglnuSpO5EMbgJMNEPFGaiDe8OUjvrJ2WcYcBSLgqynu9jaPFvZHMl83ybMvp6aDIDARjTFIBpRWod6p32fL9LIpIStvc6k8Wrs1",
Expand Down
Loading