Skip to content

⚒️🎨 Migrate conversation list to Composables#5989

Open
AndyScherzinger wants to merge 13 commits intomasterfrom
chore/noid/migrateConvListPartsToComposables
Open

⚒️🎨 Migrate conversation list to Composables#5989
AndyScherzinger wants to merge 13 commits intomasterfrom
chore/noid/migrateConvListPartsToComposables

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Mar 20, 2026 •
edited
Loading

🖼️ Screenshots

🏚️ Before 🏡 After
dark_old Screenshot_20260324_200532
light_old Screenshot_20260324_200514
search_old search_new

🚧 TODO

  • review
  • fix
  • merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added 2. developing Work in progress technical debt Technical issue labels Mar 20, 2026
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch 17 times, most recently from 9bdd4b0 to 2032114 Compare March 23, 2026 19:14
@AndyScherzinger AndyScherzinger changed the title ⚒️🎨 Migrate conv list parts to composables ⚒️🎨 Migrate conversation list to Composables Mar 23, 2026
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch 7 times, most recently from 224302d to 32c1724 Compare March 24, 2026 15:03
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews design Related to the design and removed 2. developing Work in progress labels Mar 24, 2026
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch from 32c1724 to f40b1dd Compare March 24, 2026 19:06
@AndyScherzinger AndyScherzinger marked this pull request as ready for review March 24, 2026 19:31
@AndyScherzinger
chore(conv-list): Migrate status banner to Composable
ce51411 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(conv-list): Migrate empty state to Composable
7f09ed5 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(conv-list): Migrate FAB to Composable
8e81c98 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(conv-list): use searchBehaviorSubject.value
d429bc7 
... instead of repeated subscriptions which did not get disposed

AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(conv-list): Migrate FAB to Composable
011d2ea 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore(conv-list): Migrate Shimmer to Composable
487cd52 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate notification warning card to Composable
5d04940 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate federation invitation card to Composable
283dcd4 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Create conversation item Composable
36c2094 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Create conversation list Composable
54a6b56 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(conv-list): resize fab to properly show the drop shadow
ba563d9 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate top bars to Composable
9ae89e8 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(conv-list): Migrate conversation list screen
5763c13 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/migrateConvListPartsToComposables branch from f40b1dd to 5763c13 Compare March 25, 2026 07:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5989.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2026

Codacy

Lint

TypemasterPR
Warnings9394
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design technical debt Technical issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyScherzinger