feat(plugins): P3c — secret() redaction (D37) + app-config permissions (D36)#105
Merged
aqib-rx merged 3 commits intoJun 17, 2026
Merged
Conversation
Contributor
PR title fails Conventional Commits checkExamples of valid titles:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the P3 remainder, stacked on P3b. Ships two of the three planned components; D35 (ctx.services elevation) was deferred — see below.
secret()redaction primitive (@nextlyhq/plugin-sdk):Secret<T>/secret()/isSecretthat auto-redact viatoJSON/toString/util.inspect(→[redacted]) with explicit.reveal(). Protects logs,NextlyError.logContext, anyJSON.stringify. Framework-free; no collection field type (matches D37's "via env/config only").config.permissions?: PluginPermission[]onNextlyConfig/NextlyServiceConfig(+ sanitize +buildServiceConfigthreading);collectCustomPermissionsfolds app perms (ownerapp) under the same collision rules as plugin perms. Seeds via the existing P3a boot/post-init wiring.D35 deferred (honest note)
The combined plan assumed
ctx.services.collectionswas the entry service(params{user,overrideAccess}, body). The real facade isdomains/.../collection-service.ts(name, data, context: RequestContext)— no override path, throws on denial, used by the direct API, andRequestContext.user({id,email,role,permissions}) is incompatible withAuthUser. Real{as:'system'}needs additive overrideAccess threading through the shared facade + reconciling 3 user types — a design-sensitive core change, not a pure wrapper. The wrong-shapedServiceOpts/translator work was reverted; D35 gets its own brainstorm. So P3 is not fully complete — D35 remains.Test Plan
Stacked on
feat/plugin-p3b-client-gating; retarget tofeat/plugin-platformafter the earlier P3 PRs merge. No changeset.