subsample: Don't validate schema in helper functions - #2039
Merged
Conversation
This change is primarily intended for pathogen workflows that use the helper functions prior to running augur subsample, commonly during Snakemake's initialization step. Schema is still validated at run time. We are shifting to a pattern where pathogen workflows define and validate their own schema at workflow start, so the validation in these helper functions is unnecessary duplicate work.
victorlin
force-pushed
the
victorlin/subsample-schema-validation
branch
from
August 12, 2026 23:45
974cd06 to
8752942
Compare
joverlee521
approved these changes
Aug 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2039 +/- ##
=======================================
Coverage 73.25% 73.26%
=======================================
Files 86 86
Lines 10766 10765 -1
Branches 2099 2099
=======================================
Hits 7887 7887
+ Misses 2504 2503 -1
Partials 375 375 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This change is primarily intended for pathogen workflows that use the helper functions prior to running augur subsample, commonly during Snakemake's initialization step. Schema is still validated at run time.
We are shifting to a pattern where pathogen workflows define and validate their own schema at workflow start, so the validation in these helper functions is unnecessary duplicate work.
Related issue(s)
Example with measles:
Checklist
Automated checks passfailures unrelated