Use augur subsample - #62
Merged
Merged
Conversation
…/vendored subrepo: subdir: "shared/vendored" merged: "5b4c394" upstream: origin: "https://github.com/nextstrain/shared" branch: "main" commit: "5b4c394" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "4f60dd7"
Preparing to use shared Snakemake files in the phylogenetic workflow.
Useful for debugging.
For consistency with other pathogen repos.
victorlin
commented
Aug 4, 2026
victorlin
force-pushed
the
victorlin/use-augur-subsample
branch
from
August 4, 2026 22:19
7f7a817 to
e669bec
Compare
joverlee521
approved these changes
Aug 4, 2026
joverlee521
left a comment
joverlee521
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the changelog! Left a small comment, but main changes LGTM.
For consistency with other pathogen repos. I've simply swapped both `augur filter` calls to `augur subsample`. More work could be done to improve the workflow DAG and avoid having two of the same rule, but that's for later.
victorlin
force-pushed
the
victorlin/use-augur-subsample
branch
from
August 4, 2026 23:11
e669bec to
84e707c
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR makes minimal changes to use
augur subsamplein the phylogenetic workflow.Related issue(s)
Closes #61
Checklist