[2] Add default serializers and serializer type hints#19
Closed
[2] Add default serializers and serializer type hints#19
Conversation
mjameswh
changed the title
mjameswh
force-pushed
the
serializer-cp2
branch
from
d498d8d to
aacfe43
Compare
Contributor
|
Removed myself as a reviewer, please ask for another review if and when this becomes ready or close the PR if it is no longer needed. |
cretz
reviewed
Nov 18, 2025
| import { it, describe } from "node:test"; | ||
| import * as assert from "node:assert/strict"; | ||
| import * as nexus from "../index"; | ||
| import { defaultSerializers } from "../serialization/serializers"; |
There was a problem hiding this comment.
I do not believe Nexus SDKs need to offer default serializers at this time. I think only Go does, and I think it did so prematurely as part of expected non-Temporal use. I think we should hold off on this until we're willing to commit to doing this across SDKs.
Contributor
|
Given the direction of leaving serialization up to the protocol, I'm closing this out. Will use this as reference if we decide to revisit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CompositeSerializer,NullSerializer,BinarySerializerandJsonSerializer.ServiceRegistrynow owns the serializer, receiving it as part of theServiceRegistryinitialization, rather than the serializer being somehow attached to eachLazyValue.