Fix ErrorBoundary retry test: resolve re-throw race condition#9
Draft
Fix ErrorBoundary retry test: resolve re-throw race condition#9
Conversation
Co-authored-by: nexusct <19503275+nexusct@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze repository and test all code
Fix ErrorBoundary retry test: resolve re-throw race condition
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
"provides try again button that resets error state"test was failing because clicking "Try Again" before providing new children caused a re-throw cycle: the boundary reset tohasError: false, synchronously re-rendered the still-throwing children, andgetDerivedStateFromErrorfired again beforererendercould supply the non-throwing replacement.Fix
Swap the order of
rerenderandfireEvent.clickin the test to reflect the correct lifecycle: parent provides updated children first, then the user retries.When "Try Again" is clicked, the boundary resets state and renders the already-updated (non-throwing) children, completing the retry successfully.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.