Introduce NXemission_line base class#1619
Open
mretegan wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
The PR now adds three more base classes.
|
Contributor
|
From Telco Apr 29: general approval was received. There were rumblings of linking to external databases instead of having copies of things such as the periodic table, but the consensus was that this could be ok. There are implications to other base clases, e.g. NXchemical_composition which has an ELEMENT field of type NXatom, and in contributed, NXsubstance. This should be discussed more, such as should we introduce a new base class, NXelement, or should the XAS application definitions use NXatom instead? |
Contributor
Author
|
After looking at |
Contributor
|
Great, @mretegan will you provide a new version then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces a new base class to describe an emission line. This base class will be used in the updated XAS definition (see #1352)
Because this may be of broader interest, and to make the review of the forthcoming XAS application definition easier, this base class is being submitted as a separate PR.
A question that came up in our previous discussion (XraySpectroscopy#8) was how to group together multiple emission lines.
NXcollectionwas discarded as it is not validated. Another proposed alternative wasNXobject(XraySpectroscopy#8 (comment)) or using a new container classNXemission_lines, which would result in an HDF5 structure looking like this: