Open
Conversation
TCLamnidis
reviewed
Apr 10, 2026
Collaborator
TCLamnidis
left a comment
TCLamnidis
left a comment
There was a problem hiding this comment.
Thanks @bentsherman! Generally looks great!
I am a bit cautious about applying changes to the nf-core/modules files here, but I'm happy to suggest these changes on the source modules.
Author
|
I think all nf-core modules have already been updated for strict syntax, so you don't need to push my changes upstream, you only need to update them the normal way. I didn't do that here because I'm lazy 😄 |
Collaborator
|
perfect! we need to do a mass module update pre release anyway, so I will merge all other changes of yours in ^_^ Thank you for the help! It is much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, just fixing some strict syntax errors so that I can test nf-core/eager with Nextflow 26.04
This one was pretty straightforward. Let me know if the changes make sense