Conversation
|
@nf-core-bot fix linting |
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
|
@jkh00 Hiii, I noticed you mentioned there was still something to be done, and I was just wondering if you have any idea when it might be finished?😊 |
Signed-off-by: YiJin-Xiong <yshico@163.com>
|
Hii, I will try to implement some of them next week. But right now I have some other priorities, so it might be going in a slower pace.. you are more than welcome to contribute too! 😊 i think the compressing part should be easy to implement |
|
Sure! I'll try to handle them these two days! |
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
|
@YiJin-Xiong thanks alot for the help! I will get my hands on in the next two days :)) |
|
@nf-core-bot fix linting |
|
@nf-core-bot fix linting |
|
@YiJin-Xiong Hi! sorry i was away for the past months, but now I have updated the modkit modules and also updated versions output for most nf-core modules. from my side the updates are completed. if you agree with the changes, then its ready to merge :) |
YiJin-Xiong
left a comment
There was a problem hiding this comment.
@jkh00 Glad you're back!! I noticed the versions output has changed a lot, and I've reviewed all the updates, they look great to me. Just some tiny issues.
|
@YiJin-Xiong thank you again for the assistants and feedbacks!! always a pleasure to work with you :) glad to be improving the pipeline with you. |
|
@jkh00 Thanks so much for your kind words, I really appreciate it!! It's truly a pleasure working with you as well, and I've learned a lot through our collaboration. 🫶🫶 |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).This patch release is meant to address some bugs.
--all-contextsis set, the default dmr analysis is by modkit because DSS only process CpG island.--combine-strandsinmodkit pileupmodkit pileupmodule--motif A 0with--modified-bases 6mAinmodkit pileup, because version v0.6.0 will give this error otherwiseError! single base motifs not supported, use --modified-bases.modkit pileupmodule now directly output bgzf-compressed bedmethylmodkit pileupoutput