Skip to content

Patch 2.0.1#78

Merged
jkh00 merged 73 commits intodevfrom
patch-2.0.1
Apr 7, 2026
Merged

Patch 2.0.1#78
jkh00 merged 73 commits intodevfrom
patch-2.0.1

Conversation

@jkh00
Copy link
Copy Markdown
Collaborator

@jkh00 jkh00 commented Nov 27, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylong branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This patch release is meant to address some bugs.

  • fix caching issue
  • when --all-contexts is set, the default dmr analysis is by modkit because DSS only process CpG island.
  • remove --combine-strands in modkit pileup
  • all output, if possible should be compressed
  • update modkit versions
  • update modkit pileup module
  • replace --motif A 0 with --modified-bases 6mA in modkit pileup, because version v0.6.0 will give this error otherwise Error! single base motifs not supported, use --modified-bases.
  • update output structures and documentation
  • update affected subworkflows, where the modkit pileup module now directly output bgzf-compressed bedmethyl
  • inspect modkit pileup output
  • migrate versions to topic

@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Nov 27, 2025

@nf-core-bot fix linting

nf-core-bot and others added 2 commits November 27, 2025 16:08
Signed-off-by: YiJin-Xiong <yshico@163.com>
Comment thread subworkflows/local/shared_modkit_dmr_population_scale/main.nf Outdated
Signed-off-by: YiJin-Xiong <yshico@163.com>
@YiJin-Xiong
Copy link
Copy Markdown
Member

@jkh00 Hiii, I noticed you mentioned there was still something to be done, and I was just wondering if you have any idea when it might be finished?😊

Signed-off-by: YiJin-Xiong <yshico@163.com>
@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Dec 5, 2025

Hii, I will try to implement some of them next week. But right now I have some other priorities, so it might be going in a slower pace.. you are more than welcome to contribute too! 😊 i think the compressing part should be easy to implement

@YiJin-Xiong
Copy link
Copy Markdown
Member

Sure! I'll try to handle them these two days!

YiJin-Xiong and others added 6 commits December 8, 2025 15:27
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
Signed-off-by: YiJin-Xiong <yshico@163.com>
@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Dec 9, 2025

@YiJin-Xiong thanks alot for the help! I will get my hands on in the next two days :))

@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Apr 2, 2026

@nf-core-bot fix linting

@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Apr 2, 2026

@nf-core-bot fix linting

@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Apr 2, 2026

@YiJin-Xiong Hi! sorry i was away for the past months, but now I have updated the modkit modules and also updated versions output for most nf-core modules. from my side the updates are completed. if you agree with the changes, then its ready to merge :)

Copy link
Copy Markdown
Member

@YiJin-Xiong YiJin-Xiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkh00 Glad you're back!! I noticed the versions output has changed a lot, and I've reviewed all the updates, they look great to me. Just some tiny issues.

Comment thread bin/call_dss.py
Comment thread conf/modules.config Outdated
Comment thread conf/modules.config Outdated
@jkh00
Copy link
Copy Markdown
Collaborator Author

jkh00 commented Apr 7, 2026

@YiJin-Xiong thank you again for the assistants and feedbacks!! always a pleasure to work with you :) glad to be improving the pipeline with you.
I have also received your email, will reply to you shortly!

@jkh00 jkh00 merged commit 7b03e9a into dev Apr 7, 2026
28 checks passed
@YiJin-Xiong
Copy link
Copy Markdown
Member

@jkh00 Thanks so much for your kind words, I really appreciate it!! It's truly a pleasure working with you as well, and I've learned a lot through our collaboration. 🫶🫶

@jkh00 jkh00 mentioned this pull request Apr 14, 2026
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants