Corrections in 2022/2023 draft trades#32
Open
robert-moore wants to merge 3 commits into
Open
Conversation
Five trades had exact-duplicate rows for the same pick slot (identical trade_id/gave/received/pick_season/pick_number). Five duplicate rows removed: - trade_id 1649: duplicate PHI→HOU pick 166 - trade_id 1656: duplicate GB→MIN pick 59 - trade_id 1660: duplicate HOU→CLE pick 124 - trade_id 1759: duplicate DET→ARI pick 168 - trade_id 1773: duplicate PHI→HOU pick 248 Three trades had a player (pfr_id) attached to the wrong pick slot — each involved two picks from the same round where the second pick's number was recorded as a copy of the first. Corrected pick_number values: - trade_id 1671: Esezi Otomewo (OtomEs00) 169 → 165 - trade_id 1674: Malcolm Rodriguez (RodrMa00) 198 → 188 - trade_id 1681: Daniel Hardy (HardDa01) 261 → 235 All corrections verified against load_draft_picks() for the same season.
Trade 1649 (2022, PHI→HOU): the duplicate pick 166 row was actually a second 5th-round pick — corrected to pick 168. PHI sent HOU picks 15, 124, 166, and 168 in exchange for pick 13 (Jordan Davis). Trade 1773 (2023, PHI→HOU): the duplicate pick 248 row was actually a second 7th-round pick — corrected to pick 230. PHI sent HOU picks 230 and 248 in exchange for pick 191.
All five originally labelled as 'pure duplicates' were actually a second pick from the same round recorded with the wrong slot number — none should have been deleted. Trade 1656 (2022): GB gave MIN picks 53 + 59 for pick 34. Second 2nd-round pick corrected from 59 to 53. Trade 1660 (2022): HOU gave CLE picks 68, 108, + 124 for pick 44. Second 4th-round pick corrected from 124 to 108. Trade 1759 (2023): DET gave ARI picks 122, 139, + 168 for pick 96. Second 5th-round pick corrected from 168 to 139.
robert-moore
changed the title
Author
|
Hey @leesharpe would love to get this merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eight trades in
data/trades.csvhave incorrectpick_numbervalues. All eight follow the same root cause: a trade that sent two picks from the same round, where the second pick's slot was recorded as a copy of the first instead of the correct value.In five cases the rows had no
pfr_id(anonymous pick rows), making the error less obvious. In three cases a player'spfr_idmakes the correct slot identifiable by joining toload_draft_picks().All eight corrections
trade_idpfr_nameload_draft_picks()load_draft_picks()load_draft_picks()To reproduce (Category 2 — player rows)