Updating param name from connector_i_ds to connector_ids in RFmx VNA#1237
Open
RahulBenaka wants to merge 1 commit intomainfrom
Open
Updating param name from connector_i_ds to connector_ids in RFmx VNA#1237RahulBenaka wants to merge 1 commit intomainfrom
RahulBenaka wants to merge 1 commit intomainfrom
Conversation
astarche
reviewed
Jan 30, 2026
| @@ -1,2 +1,91 @@ | |||
| functions_override_metadata = { | |||
| 'CalkitManagerCalkitCalibrationElementGetPortConnectors': { | |||
Collaborator
There was a problem hiding this comment.
Normally we fix this by adding a transform in scrapigen that updates grpc_name in the functions.py file. I have never used functions_addon (I think) since I've worked on grpc-device. Maybe that was originally for some MI APIs where functions.py was an external source-of-truth. But for RFmx, we are already generating the metadata for grpc-device from scrapigen, so we can include it in the primary functions.py metadata.
I wonder if just adding IDs or something similar to ADDITIONAL_ACRONYMS would fix this? Maybe this case is slightly different from other analyze_acronyms use-cases. You can also have a custom transform that patches a specific parameter name with a grpc_name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
For APIs in VNA with parameter name as connectorIDs (in metadata), the name was appearing as connector_i_ds in proto and respective service files. This PR aims to resolve that naming issue and correct it to connector_ids. This is achieved by making these API function metadata as special i.e. adding it to functions_addon and leverage 'grpc_name' field to add the appropriate name to be reflected in proto and respective service files
Why should this Pull Request be merged?
This name change from connector_i_ds to connector_ids is required for legibility and this will help us to maintain python gRPC code for RFmx use the appropriate naming convention.
What testing has been done?
Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxvna/export/ to grpc-device/source/codegen/metadata/nirfmxvna/ and hardcoded these new param names by using 'grpc_name' field and built grpc-device successfully.
Manually inspected nirfmxvna.proto file.