Pass gRPC id into Register Reflection Descriptors.vi#459
Merged
Conversation
jasonmreding
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the connector pane of
Register Reflection Descriptors.vito pass in/out the gRPC server id. This is in preparation for in-progress PR #457 where reflection descriptor strings are registered to a specific gRPC server. Currently, the gRPC server id is only passed in and out of the function.Note that this is not a breaking change as the VI
Register Reflection Descriptors.viwas created after the last v1.5.1.1 release. However, as PR #457 will likely not be part of upcoming v1.6.0.1 release, this PR will provide the connector pane update to avoid a breaking change in the future.No changes to the existing reflection functionality occurs as part of this PR.