Partial Solution to Server Regeneration When Modifying .proto File#509
Open
Madd3DScientist wants to merge 2 commits into
Open
Partial Solution to Server Regeneration When Modifying .proto File#509Madd3DScientist wants to merge 2 commits into
Madd3DScientist wants to merge 2 commits into
Conversation
- script and README - facilitates addition or subtraction of functionality from server Signed-off-by: Damien Gray <damien.gray@3dsystems.com>
Signed-off-by: Damien Gray <damien.gray@3dsystems.com>
Collaborator
|
@Madd3DScientist I posted #513 which I'm hoping eliminates the need to submit these types of scripting/tooling work arounds. If you have time to look at and test these changes against the services you have been working with, I would be interested to hear your feedback. In particular, I'm curious whether that PR mostly addresses the needs that caused you to write this script or what other pain points remain where you would still keep this script around. |
Contributor
Author
|
I should get a chance to check it this week. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.protofile then regenerating the server would work. It does not. Currently, the programmer must generate a differently named server, copy the code from the event structures from the old to the new, delete the old and rename the new. As servers get larger, this gets more difficult and it is easy to make mistakes.Ideally, the server creation script would scan the project for current elements and modify if present, rather than failing. However, writing that script would take awhile. Thus, this workaround.