Initial submission of workflow files with simplified CI.#7
Merged
mjohanse-emr merged 3 commits intomainfrom Jun 24, 2025
Merged
Initial submission of workflow files with simplified CI.#7mjohanse-emr merged 3 commits intomainfrom
mjohanse-emr merged 3 commits intomainfrom
Conversation
Signed-off-by: Michael Johansen <michael.johansen@ni.com> Fix the working directory setting. Signed-off-by: Michael Johansen <michael.johansen@ni.com> Specify working directory for pyright. Signed-off-by: Michael Johansen <michael.johansen@ni.com> I put the input in the wrong spot. Signed-off-by: Michael Johansen <michael.johansen@ni.com> Remove unused workflows. They will be added in later. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
b00a993 to
9a9dbb2
Compare
bkeryan
approved these changes
Jun 24, 2025
Collaborator
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
added 2 commits
June 24, 2025 14:25
…ck yml files. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
bkeryan
reviewed
Jun 24, 2025
| on: | ||
| workflow_call: | ||
| inputs: | ||
| package_name: |
Collaborator
There was a problem hiding this comment.
Action parameters typically use kebab-case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add CI and PR workflows that perform a subset of the steps they will eventually perform. Right now, they only run the
check_<package>.ymlworkflows.The rest of the workflow files have been left out for now (check docs, unit tests, etc.). I'll add them back in when I start using them from CI.yml.
Why should this Pull Request be merged?
Initial steps for AB#3166738
What testing has been done?
PR/CI checks pass.