Align session-id copy with prefix addressing#66
Open
nertzy wants to merge 1 commit into
Open
Conversation
The intercom tool renders each session in "list" as name (shortId), but the tool description, the "to" param help, and the duplicate-name error never told the caller that the parenthesized short id is itself a valid target. Agents read "Use the session ID instead", saw only the short id, and had no signal that it resolves - producing repeated send/ask failures whenever two sessions shared a name. resolveSessionTarget already resolves a leading ID prefix; this aligns the human/agent-facing copy with that behavior: - duplicate-name error now points at the short ids shown by "list" - tool description and "to" param document name / full ID / short-id-prefix - add a test asserting the collision error names both short ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Align the intercom tool's human/agent-facing copy with how session addressing actually resolves.
listrenders every session asname (shortId)(the leading 8 chars of the session ID).resolveSessionTargetalready accepts a leading ID prefix, so that short id is a valid target - but nothing told the caller that:Use the session ID instead.whilelistonly ever shows the short id, so the caller had no addressable identifier;descriptionand thetoparam help only mentioned "name or ID".Agents (and humans) hit this whenever two sessions share a name: name-addressing throws, the only visible id looks un-addressable, and
send/askfail in a loop.Change
list, e.g.Multiple sessions named "twin" are connected. Address one by the id shown in parentheses by "list" (aaaa1111, bbbb2222).description+toparam document name / full ID / short-id-prefix as valid targets.No behavior change to
resolveSessionTarget- prefix resolution already existed onmain; this makes the surface copy match it.Test
npm test- 92 pass.