fix: product variants cannot be purchased (checkout and webhook)#512
Open
devprashant19 wants to merge 2 commits into
Open
fix: product variants cannot be purchased (checkout and webhook)#512devprashant19 wants to merge 2 commits into
devprashant19 wants to merge 2 commits into
Conversation
|
@devprashant19 is attempting to deploy a commit to the niharika-mente's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@Aamod007 solved conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical bug where users were unable to purchase product variants. Previously, the checkout logic always checked the
baseStockand usedbasePrice, causing errors and crashes for products with variants.Fixes #487
Changes
BACKEND/controllers/checkout.controller.js:createCheckoutSessionto dynamically identify if a product has variants, validate the requestedvariantId, and correctly use the variant's price and stock.variantIdtracking into the Stripe session metadata.stripeWebhooklogic to parse thevariantIdand correctly decrementvariants.$.stockinstead ofbaseStock.restoreStockhelper to support restoring variant inventory upon payment failures.