Skip to content

fix(backend): fail open on rate limiter connection errors (fix #125)#129

Merged
nirakarpatel merged 1 commit into
niharika-mente:mainfrom
Pratyush-Panda-2006:fix-rate-limiter-fail-open-issue-125
Jul 8, 2026
Merged

fix(backend): fail open on rate limiter connection errors (fix #125)#129
nirakarpatel merged 1 commit into
niharika-mente:mainfrom
Pratyush-Panda-2006:fix-rate-limiter-fail-open-issue-125

Conversation

@Pratyush-Panda-2006

Copy link
Copy Markdown
Contributor

Description

This pull request prevents the backend application from failing closed when the rate-limiting provider (Upstash Redis) is down, misconfigured, or times out. Previously, if ratelimit.limit() encountered any connection exception, the rate-limiter middleware caught the error and returned a 500 Internal Server Error, completely blocking all API requests.

Changes

  • Updated backend/src/middleware/rateLimiter.js to log the connection exception (console.error) and call next() to allow the request to proceed (fail open) rather than returning a 500 error.

Fixes #125

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Pratyush-Panda-2006, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 28406a46-2504-4afe-b7f0-f871f3f1c6b6

📥 Commits

Reviewing files that changed from the base of the PR and between b0bd964 and af94350.

📒 Files selected for processing (1)
  • backend/src/middleware/rateLimiter.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nirakarpatel nirakarpatel added bug Something isn't working documentation Improvements or additions to documentation SSoC26 Medium Hard and removed Medium labels Jul 8, 2026
@nirakarpatel nirakarpatel merged commit f615d37 into niharika-mente:main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation Hard SSoC26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG/RESILIENCE] Rate limiter catches connection errors and blocks all API traffic with 500 errors

2 participants