fix(backend): delete child notes when their parent note is deleted (fix #134)#139
Open
Pratyush-Panda-2006 wants to merge 1 commit into
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
34cf8ac to
8d62734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request prevents child notes from being orphaned in the database when a parent note or stack container is deleted. Previously, when
deleteNotewas invoked, the parent note was deleted viafindOneAndDeletebut its child notes (associated viaparentId) remained in MongoDB, bloating the database with unreachable records.Changes
deleteNotecontroller inbackend/src/controllers/notesController.jsto executeNote.deleteMany({ parentId: id, userId: req.user._id })after the parent note is successfully deleted.Fixes #134
Summary by CodeRabbit
Bug Fixes
Documentation