Add support for python 3.13#135
Conversation
nikdon
commented
Jul 4, 2025
- add python 3.13 to the build matrix
- updates of the dependencies
There was a problem hiding this comment.
Pull Request Overview
This PR adds Python 3.13 support to the CI matrix, bumps the package to version 2.0.0, updates dependencies, and refactors the GitHub Actions workflow.
- Bump package version from 1.0.0 to 2.0.0 in setup.py and pyproject.toml
- Add
coveragedependency and update Ruff’starget-versionin pyproject.toml - Extend CI matrix with Python 3.13 and split lint/test steps in the workflow
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Updated version to 2.0.0 |
| pyproject.toml | Bumped version, added coverage, removed major_version_zero, changed Ruff target-version |
| CHANGELOG.md | Added empty 2.0.0 release header |
| .github/workflows/python-package.yml | Added Python 3.13 to matrix, revamped caching key, split lint and test steps |
Comments suppressed due to low confidence (2)
.github/workflows/python-package.yml:41
- This step references
steps.cached-poetry-dependencies.outputs.cache-hit, but the preceding cache step has noid, so this output will be undefined. Add anid(for exampleid: cached-poetry-dependencies) to the cache action.
if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
CHANGELOG.md:3
- The new 2.0.0 changelog section is currently empty; it would be helpful to include a summary of key changes or features introduced in this release.
## 2.0.0 (2025-07-04)
| [tool.ruff] | ||
| line-length = 120 | ||
| target-version = "py310" | ||
| target-version = "py39" |
There was a problem hiding this comment.
The Ruff target-version is set only to Python 3.9 but this project now supports multiple versions; update it to include all supported versions, e.g., target-version = ["py39", "py310", "py311", "py312", "py313"].
| target-version = "py39" | |
| target-version = ["py39", "py310", "py311", "py312", "py313"] |
| [tool.poetry] | ||
| name = "pyentrp" | ||
| version = "1.0.0" | ||
| version = "2.0.0" |
There was a problem hiding this comment.
[nitpick] The package version is defined in both setup.py and pyproject.toml, which can drift out of sync. Consider centralizing version management (e.g., using version_files exclusively) to ensure a single source of truth.
| version = "2.0.0" |