Skip to content

Add support for python 3.13#135

Merged
nikdon merged 4 commits into
masterfrom
feat/py313
Jul 4, 2025
Merged

Add support for python 3.13#135
nikdon merged 4 commits into
masterfrom
feat/py313

Conversation

@nikdon

@nikdon nikdon commented Jul 4, 2025

Copy link
Copy Markdown
Owner
  • add python 3.13 to the build matrix
  • updates of the dependencies

@nikdon
nikdon requested a review from Copilot July 4, 2025 15:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Python 3.13 support to the CI matrix, bumps the package to version 2.0.0, updates dependencies, and refactors the GitHub Actions workflow.

  • Bump package version from 1.0.0 to 2.0.0 in setup.py and pyproject.toml
  • Add coverage dependency and update Ruff’s target-version in pyproject.toml
  • Extend CI matrix with Python 3.13 and split lint/test steps in the workflow

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
setup.py Updated version to 2.0.0
pyproject.toml Bumped version, added coverage, removed major_version_zero, changed Ruff target-version
CHANGELOG.md Added empty 2.0.0 release header
.github/workflows/python-package.yml Added Python 3.13 to matrix, revamped caching key, split lint and test steps
Comments suppressed due to low confidence (2)

.github/workflows/python-package.yml:41

  • This step references steps.cached-poetry-dependencies.outputs.cache-hit, but the preceding cache step has no id, so this output will be undefined. Add an id (for example id: cached-poetry-dependencies) to the cache action.
      if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'

CHANGELOG.md:3

  • The new 2.0.0 changelog section is currently empty; it would be helpful to include a summary of key changes or features introduced in this release.
## 2.0.0 (2025-07-04)

Comment thread pyproject.toml
[tool.ruff]
line-length = 120
target-version = "py310"
target-version = "py39"

Copilot AI Jul 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ruff target-version is set only to Python 3.9 but this project now supports multiple versions; update it to include all supported versions, e.g., target-version = ["py39", "py310", "py311", "py312", "py313"].

Suggested change
target-version = "py39"
target-version = ["py39", "py310", "py311", "py312", "py313"]

Copilot uses AI. Check for mistakes.
Comment thread pyproject.toml Outdated
[tool.poetry]
name = "pyentrp"
version = "1.0.0"
version = "2.0.0"

Copilot AI Jul 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The package version is defined in both setup.py and pyproject.toml, which can drift out of sync. Consider centralizing version management (e.g., using version_files exclusively) to ensure a single source of truth.

Suggested change
version = "2.0.0"

Copilot uses AI. Check for mistakes.
@nikdon nikdon self-assigned this Jul 4, 2025
@nikdon
nikdon merged commit 23fa32f into master Jul 4, 2025
8 checks passed
@nikdon
nikdon deleted the feat/py313 branch July 4, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants