fix: resolve critical config errors, type mismatches, and memory leaks#17
Open
nikomatt69 wants to merge 1 commit intomainfrom
Open
fix: resolve critical config errors, type mismatches, and memory leaks#17nikomatt69 wants to merge 1 commit intomainfrom
nikomatt69 wants to merge 1 commit intomainfrom
Conversation
## Summary - Fix Cargo.toml: removed duplicate plugins, invalid biometric version - Fix tsconfig.json: added missing baseUrl, updated ES target to ES2020 - Fix next.config.js: removed static export incompatible with Tauri - Fix tauri.conf.json: fixed identifier, CSP policy, removed invalid resources - Fix GitHub workflows: corrected syntax errors, updated Ubuntu/Node versions - Fix VSCode package.json: aligned publisher, added missing vsce dependency - Fix package.json: corrected framer-motion version, aligned Tauri plugins ## Type Fixes - Unified duplicate ApiKey, UserPreferences, MLEngineStatus interfaces - Fixed environment values mismatch (dev → development) - Fixed dependencies deduplication bug in apiProviderService ## Memory Leaks & Performance - Fixed setInterval cleanup in integrationService - Added cache size limits and cleanup in llmProxyService - Fixed race conditions in MLService initialization ## Component Fixes - Added null safety checks in Sidebar - Removed unused imports across components - Added accessibility attributes to BottomSheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed 85+ issues across the codebase identified through comprehensive code analysis.
Critical Config Fixes
Cargo.tomltauri-plugin-keyring, invalidtauri-plugin-biometric: 2.0.0tsconfig.jsonbaseUrl, ES5 target incompatible with ES modulesbaseUrl: ".", changed target toES2020next.config.jsoutput: 'export'breaks Tauritauri.conf.jsonbuild.ymlsecurity.ymlcontinue-on-errorrelease.ymlVSCode package.jsoncadcamfun, added vscepackage.jsonframer-motion: ^12.23.6, beta plugins^11.0.0, aligned plugin versionsType/Logic Fixes
ApiKey,UserPreferences,MLEngineStatusinterfacesdependencies[0]bug creating Set of characters →[...new Set(dependencies)]"dev"→"development")Memory Leaks & Performance
setIntervalcleanup inintegrationService- intervals now cleared inreset()llmProxyServicewithmaxCacheSizeComponent Fixes
Sidebar.tsxrole,tabIndex,aria-label) toBottomSheet.tsxFiles Changed