Conversation
Put version back in agent name field so the orange badge shows 'shipkit v0.1.12'. Update cli.py run command to pass the versioned name to --agent so it matches correctly.
The agent name now includes a version suffix (e.g., "shipkit v0.1.12"), so the assertion needs to check startsWith rather than exact match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shipkit v0.1.12cli.pyrun command to pass versioned name to--agentflag so it matchesPreviously the name was changed to just
shipkitto fix--agentmatching, but this lost the version display in the UI badge. Now both work: badge shows version, and the CLI passes the correct versioned name.Test plan
shipkit runlaunches with orange badge showingshipkit v0.1.12skalias also shows versioned badge