Fix Ecto.Query.CastError when querying issue by short ID#24
Open
nilszeilon wants to merge 5 commits intomainfrom
Open
Fix Ecto.Query.CastError when querying issue by short ID#24nilszeilon wants to merge 5 commits intomainfrom
nilszeilon wants to merge 5 commits intomainfrom
Conversation
The refresh button in the dashboard now shows visible 'Refresh' text to make it accessible and match test expectations.
Allows API to accept short IDs like 'd668facb' in addition to full UUIDs. When a short ID is passed, the issue is looked up by matching the first 8 characters of the UUID. Full UUIDs continue to work as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ecto.Query.CastErrorwhen querying issues by short ID (e.g.,d668facb)get_issue_by_short_id/1was usinglike/2on a UUID field (binary_id), but Ecto couldn't cast the string pattern to binary_idFixes the API error: