Skip to content

feat: change-2-secret-blocking — deterministic secret blocking - #18

Merged
nimser merged 1 commit into
mainfrom
change-2-secret-blocking
Jul 5, 2026
Merged

feat: change-2-secret-blocking — deterministic secret blocking#18
nimser merged 1 commit into
mainfrom
change-2-secret-blocking

Conversation

@nimser

@nimser nimser commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Maps to private/openspec/changes/change-2-secret-blocking.

Ships the six secret rule packs off main as an independently mergeable slice: env, sops, private-key, encryption-tools, secret-managers, and hardening (nonOverridable, ADR-007), plus the engine plumbing they need (createEngine, pack loader, capability presets) and the gap fixes from #17 (redirect/tee blocks, SSH-directory predicate, key-extension coverage).

Deliberately excluded — left in #15 (steering-first surface): steering packs (change-18), the user-input pasted-secret rule (change-17), and the Claude Code adapter (change-7). Core type support for the user-input phase rides along here because it is woven through the validator/normalizer; no shipped rule uses it yet.

Replaces #17.

🤖 Generated with Claude Code

https://claude.ai/code/session_017yduNuh6QAZ63YTBwusgrW

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nimser, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4650fc57-6a61-4660-b27a-3bb77afdb169

📥 Commits

Reviewing files that changed from the base of the PR and between 9861b48 and 019c055.

📒 Files selected for processing (19)
  • .github/workflows/ci.yml
  • docs/packs.md
  • docs/rule-pack-guide.md
  • package.json
  • scripts/generate-packs-gallery.mjs
  • src/core/types.ts
  • src/engine/engine.ts
  • src/index.ts
  • src/infrastructure/yaml-pack-loader.ts
  • src/matcher/matchers.ts
  • src/packs/encryption-tools.yaml
  • src/packs/env.yaml
  • src/packs/hardening.yaml
  • src/packs/index.ts
  • src/packs/packs.test.ts
  • src/packs/predicates.ts
  • src/packs/private-key.yaml
  • src/packs/secret-managers.yaml
  • src/packs/sops.yaml
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch change-2-secret-blocking

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

✦ Six secret packs off main: env, sops, private-key, encryption-tools, secret-managers, hardening
✦ Hardening gap fixes ride along: redirect/tee blocks, ssh-dir predicate, nonOverridable packs
✦ Steering packs, user-input rules, and the Claude Code adapter stay behind in the steering-first PR
✦ Pack gallery regenerated for the six shipped packs

Co-authored-by: Claude <noreply@anthropic.com>
@nimser
nimser force-pushed the change-2-secret-blocking branch from 403ec54 to 019c055 Compare July 5, 2026 18:55
@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

@nimser
nimser merged commit e72b04a into main Jul 5, 2026
5 of 6 checks passed
@nimser
nimser deleted the change-2-secret-blocking branch July 5, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant