fix element array#66
Merged
Merged
Conversation
cmeyer
force-pushed
the
fix-element-array
branch
from
8d176fe to
23d8ad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue where basic math used to generate RGB data was not able to operate on an HDF5 dataset using inline operators. The way it addresses the issue is a general solution to ensure that the 'element' step in reducing data from higher dimensions to 1d or 2d data produces a guaranteed ndarray, which supports inline operators. This data reduction is explained here.
Please review for correctness or just to learn about the code. Comments welcome. I'd like to merge this within a few working days. This is an ad-hoc solution to nion-software/nionswift#1450. There may be other or parallel solutions. However, this seems like a good approach likely to avoid similar errors that may exist now or may arise in the future.