[FIX] defer check of file existence to workflow build stage#520
[FIX] defer check of file existence to workflow build stage#520effigies merged 1 commit intonipreps:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 84.13% 84.08% -0.06%
==========================================
Files 30 30
Lines 2874 2877 +3
Branches 380 382 +2
==========================================
+ Hits 2418 2419 +1
- Misses 381 382 +1
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51bf2c0 to
a89c5ff
Compare
a89c5ff to
8367ff3
Compare
effigies
left a comment
There was a problem hiding this comment.
LGTM. Thanks for looking into this, and apologies for letting it fall off the radar.
Have you tested this? Would it help to have an fMRIPrep image to test with? This can be backported trivially, so we can target pretty much any fMRIPrep series.
|
I am currently testing it on one of our dataset, patching a container with the file. It builds the workflow so it seems to work (though I have other unrelated issues with pre-computed derivatives). |
|
LGTM |
Attempt at fixing #400, that is still a blocker when parallelizing session processing with datalad.