Conversation
Owner
|
I forgot to mention:
1. Always do screenshots of the new screens you just added and upload as
comment following the PR push.
2. Ensure that you stick to the UI scheme used in the home screen
(`HomeActivity.kt` and `activity_home.xml`). If you do, most of your work
will be copy/paste and you will spend average 1 hour/screen.
…On Sun, Dec 11, 2022 at 10:20 PM SputnikD ***@***.***> wrote:
Initial PR to show bit of the structure on 3 screens, they are not
complete but adds all needed, fonting and correct design will follow
------------------------------
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
- efb6b57
<efb6b57>
Initial commit showing home screen amongst others
File Changes
(6 files <https://github.com/niyid/bisq2_android/pull/3/files>)
- *M* app/build.gradle
<https://github.com/niyid/bisq2_android/pull/3/files#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9>
(2)
- *M* app/src/main/java/com/bisq2/mobile/android/First3Fragment.kt
<https://github.com/niyid/bisq2_android/pull/3/files#diff-a61b3ddc6ce52fb036e66b4614e0f57a7839023ac2e15b53ecea2df0c02dc214>
(2)
- *M* app/src/main/res/layout/activity_home.xml
<https://github.com/niyid/bisq2_android/pull/3/files#diff-14fee9f19b953bca49973c3db44c821dea891dc6b7933c81fcecd12358556442>
(146)
- *M* app/src/main/res/layout/fragment_first.xml
<https://github.com/niyid/bisq2_android/pull/3/files#diff-1a1ce577f0133c485498c96b2e7b16d375616dc979886916b838764e700c8fd7>
(120)
- *M* app/src/main/res/layout/fragment_first3.xml
<https://github.com/niyid/bisq2_android/pull/3/files#diff-824b522764dd6e93eb03e61bf7eee61826e26154855a21192d6a388b8caff983>
(278)
- *M* app/src/main/res/values/strings.xml
<https://github.com/niyid/bisq2_android/pull/3/files#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103>
(2)
Patch Links:
- https://github.com/niyid/bisq2_android/pull/3.patch
- https://github.com/niyid/bisq2_android/pull/3.diff
—
Reply to this email directly, view it on GitHub
<#3>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2MWR2Z2WDCPMH3RVN3V2DWMZARXANCNFSM6AAAAAAS3HA5YY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Owner
|
Why are you making changes to Home Screen when it is already done? If you
compare to the screenshots I sent and you will see there is nothing (but
service/business logic to be added). Anyway send the screenshots from the
running app.
…On Sun, Dec 11, 2022 at 10:35 PM Oyeniyi Dada ***@***.***> wrote:
I forgot to mention:
1. Always do screenshots of the new screens you just added and upload as
comment following the PR push.
2. Ensure that you stick to the UI scheme used in the home screen
(`HomeActivity.kt` and `activity_home.xml`). If you do, most of your work
will be copy/paste and you will spend average 1 hour/screen.
On Sun, Dec 11, 2022 at 10:20 PM SputnikD ***@***.***>
wrote:
> Initial PR to show bit of the structure on 3 screens, they are not
> complete but adds all needed, fonting and correct design will follow
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #3
> Commit Summary
>
> - efb6b57
> <efb6b57>
> Initial commit showing home screen amongst others
>
> File Changes
>
> (6 files <https://github.com/niyid/bisq2_android/pull/3/files>)
>
> - *M* app/build.gradle
> <https://github.com/niyid/bisq2_android/pull/3/files#diff-51a0b488f963eb0be6c6599bf5df497313877cf5bdff3950807373912ac1cdc9>
> (2)
> - *M* app/src/main/java/com/bisq2/mobile/android/First3Fragment.kt
> <https://github.com/niyid/bisq2_android/pull/3/files#diff-a61b3ddc6ce52fb036e66b4614e0f57a7839023ac2e15b53ecea2df0c02dc214>
> (2)
> - *M* app/src/main/res/layout/activity_home.xml
> <https://github.com/niyid/bisq2_android/pull/3/files#diff-14fee9f19b953bca49973c3db44c821dea891dc6b7933c81fcecd12358556442>
> (146)
> - *M* app/src/main/res/layout/fragment_first.xml
> <https://github.com/niyid/bisq2_android/pull/3/files#diff-1a1ce577f0133c485498c96b2e7b16d375616dc979886916b838764e700c8fd7>
> (120)
> - *M* app/src/main/res/layout/fragment_first3.xml
> <https://github.com/niyid/bisq2_android/pull/3/files#diff-824b522764dd6e93eb03e61bf7eee61826e26154855a21192d6a388b8caff983>
> (278)
> - *M* app/src/main/res/values/strings.xml
> <https://github.com/niyid/bisq2_android/pull/3/files#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103>
> (2)
>
> Patch Links:
>
> - https://github.com/niyid/bisq2_android/pull/3.patch
> - https://github.com/niyid/bisq2_android/pull/3.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#3>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE2MWR2Z2WDCPMH3RVN3V2DWMZARXANCNFSM6AAAAAAS3HA5YY>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR to show bit of the structure on 3 screens, they are not complete but adds all needed, fonting and correct design will follow