Fixing the plugin to work with latest version of Trello app#2
Open
dellsala wants to merge 2 commits into
Open
Conversation
added 2 commits
March 11, 2015 15:49
…history change. No longer relies on this event being fired by the native trello app.
… added when the direct card url is used. Wasn't showing up before because the window overlay takes time to render.
Owner
|
Hi, Thanks for this. I'm not sure what this is intended to fix... The plugin still works for me so I wonder if we are being served different versions of the app? I've tried your PR locally in developer mode and it doesn't seem to behave any differently to the release. However, I am happy to merge it because this seems like a more stable approach moving forward (rather than relying on undocumented APIs). One suggestion: Can the code style match, please? Looks like you have used tabs whereas the plugin uses spaces. Also, when I use J/K on a card to go to next/previous card, I dont get the short URL button (I didn;t get that on the release either). Do you think this PR could fix that too? I couldn't see a change url event get fired though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to use the plugin yesterday it wouldn't work. I'm guessing the trello app used to publish its own "trelloUrlChanged" message, but it didn't look like that was happening anymore. The plugin now publishes the message itself based on
window.historystate changes.