Skip to content

Rules: prefetched post-type field list (ACF + registered + DB) - #11

Merged
nmbrthirteen merged 1 commit into
mainfrom
feature/rules-field-prefetch
Jun 30, 2026
Merged

Rules: prefetched post-type field list (ACF + registered + DB)#11
nmbrthirteen merged 1 commit into
mainfrom
feature/rules-field-prefetch

Conversation

@nmbrthirteen

Copy link
Copy Markdown
Owner

The rule editor's If field and Set meta key boxes are type-or-pick combos backed by /post-type-fields, but that endpoint only read raw DB meta keys — so for a post type with ACF fields (or few saved posts) the list looked empty and you had to type everything.

Now it returns: post_title/post_date + distinct DB meta keys + ACF field names (via acf_get_field_groups/acf_get_fields) + register_post_meta keys — deduped and sorted. So the dropdowns are actually populated and you pick instead of type.

86 tests green, lint clean.

…fields)

The If-field / Set-meta-key datalists were sparse because they only read raw DB
meta keys. Now /post-type-fields also returns ACF field names, register_post_meta
keys, and post_title/post_date, so the rules editor offers a real prefetched list
instead of manual typing.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nmbrthirteen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8cbf8e73-6371-4de0-8f4e-bd4ed31e7c79

📥 Commits

Reviewing files that changed from the base of the PR and between dc3383f and 21643d2.

📒 Files selected for processing (1)
  • src/Admin/RestController.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/rules-field-prefetch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nmbrthirteen
nmbrthirteen merged commit 687de4e into main Jun 30, 2026
6 checks passed
@nmbrthirteen
nmbrthirteen deleted the feature/rules-field-prefetch branch June 30, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant