Event at launch of animation#133
Open
acepero13 wants to merge 3 commits intonnattawat:masterfrom
Open
Conversation
added 3 commits
March 27, 2018 15:39
…wat#112) - The following events were added: 1. flip:start 2. unflip:start 3. unflip:done A demo can be found here: https://jsfiddle.net/acepero13/tvk43dms/11/
- Change function name
|
Why was this not merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #112 . Adding events when the flip or unflip start, could be an interesting feature in the case that we don't fully control the HTML markup. Therefore, we could control the content of the back and front sides before we flip them.
Besides the flip:start event, two more events were added: unflip:start and unflip:done.
The function flipDone was refactored to accept a list of events that fire after the flip is done.