Restore Canva sign-in: Implement textbox and instructions to capture authorization token (no protocol handler required)#44
Merged
Merged
Conversation
🚀 Build Artifacts ReadyCommit: 📦 Direct Downloads (via nightly.link):
|
noahc3
changed the title
Owner
Author
|
Confirmed Canva AI and the premium local machine learning models work after signing in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #43 by restoring the Canva sign-in by adding a textbox to the sign-in dialog to allow the user to copy and paste the URL of the "Launching Affinity" page from their browser to complete the sign-in process.
After clicking the sign-in button, the followup page now displays instructions and a textbox to complete the Canva sign-in.
This also appears to fix #12 from my testing - it's likely the crash report submission tries to include details about your Canva account and isn't prepared to handle the sign-in having been bypassed.