Conversation
…e workaround
- Upgrade vultr/vultr provider from 2.22.1 to 2.28.1 in all modules and envs/dev
- Remove null_resource attach_block_storage workaround (bug #660 fixed in 2.28.1)
- Remove lifecycle { ignore_changes = [attached_to_instance] } from vultr_block_storage
- Remove null provider dependency from block_storage module
- Set attached_to_instance directly on vultr_block_storage (native provider support)
- Add vultr-block-storage unit tests
- Update .terraform.lock.hcl with 2.28.1 provider hashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the Vultr Terraform provider from 2.22.1 to 2.28.1 and removes the block storage attachment workaround that was required due to provider bug #660.
Changes
vultr/vultr2.22.1 → 2.28.1 inenvs/devand all three Vultr modules (block_storage,firewall,instance).terraform.lock.hclupdated with 2.28.1 provider hashesnull_resource "attach_block_storage"and thelifecycle { ignore_changes = [attached_to_instance] }fromvultr_block_storage.thisattached_to_instanceis now set directly onvultr_block_storage(the fix in 2.28.1 "Avoid empty PATCH during update" makes this reliable)vultr-block-storage.tofutest.hclwith 2 test runs covering defaults and custom valuesWhy not 2.30.1
v2.30.1 has a critical
UpgradeResourceStatepanic onvultr_ssh_keyand other resources. 2.28.1 is the stable fix point.Closes #288.