Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies minor Go idiomatic fixes ("gofix") to markdown.go and header_styles.go. It replaces string concatenation (+=) in markdown.go with strings.Builder (which is already used throughout table.go), and changes var suffix = AnsiReset to the short variable declaration form suffix := AnsiReset in header_styles.go. There are no logic changes.
Changes:
- Replace string concatenation with
strings.BuilderinrenderMarkdownHeader,renderMarkdownSeparator, andrenderMarkdownRowinmarkdown.go - Refactor
var suffix = AnsiResettosuffix := AnsiResetinApplyStyleandgetSuffixinheader_styles.go
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
markdown.go |
Replaces string += concatenation in all three Markdown rendering functions with strings.Builder, consistent with table.go |
header_styles.go |
Converts var suffix = AnsiReset to idiomatic short declaration suffix := AnsiReset in two functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.