-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: ensure values are strings when passed to the functions #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR tightens the format validators so they only accept string inputs and adds tests to ensure non-string values are rejected, along with updating the npm lockfile to the v3 format.
Changes:
- Introduced a shared
ensureStringhelper inindex.jsand wired it into all exportedisFormatvalidators to throw aTypeErroron non-string inputs. - Added
ensureValidFormattests intest/formats.test.jsto assert that each validator throws aTypeErrorwith a consistent message when called with invalid types. - Regenerated
package-lock.jsonto lockfileVersion 3 with explicitpackagesmetadata, aligning with the currentpackage.jsondevDependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| index.js | Adds ensureString and applies it to nchar, nqchar, nqschar, uchar, uri, and vschar to enforce string-only inputs. |
| test/formats.test.js | Adds ensureValidFormat helper and invokes it in each test to check type validation behavior, while still exercising the existing range-based format checks. |
| package-lock.json | Updates npm lockfile to version 3 and reflects the current devDependency graph for tooling (chai, mocha, eslint, nyc, jsdoc-to-markdown, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dhensby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback, but not blocking
When writing tests I found the following problem:
This means that the OAuth test suite currently does not cover if values are not strings.
This PR fixes that by prepending a check for string type in every function.
After that we need to update OAuth2 server tests accordingly!