Skip to content

fix: update the download navigation link from /download to /en/download - #54

Merged
avivkeller merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/add-missing-en-to-download-navigation
Apr 20, 2026
Merged

fix: update the download navigation link from /download to /en/download#54
avivkeller merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/add-missing-en-to-download-navigation

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

Update the download navigation link so that it points to <root>/en/download (which is the correct page it should point to) instead of pointing to <root>/download (which contains the raw download directory listing instead)

…ownload`

Update the download navigation link so that it points to `<root>/en/download` (which is the correct page it should point to) instead of pointing to `<root>/download` (which contains the raw download directory listing instead)
Copilot AI review requested due to automatic review settings April 19, 2026 23:28
@vercel

vercel Bot commented Apr 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview Apr 19, 2026 11:28pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the top navigation “Download” link to point at the correct Node.js downloads page (/en/download) instead of /download, which leads to an unintended directory listing.

Changes:

  • Changed the navigation entry for “Download” from /download to /en/download.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller
avivkeller enabled auto-merge April 20, 2026 04:50
@avivkeller
avivkeller disabled auto-merge April 20, 2026 04:51
@avivkeller
avivkeller merged commit 6cd8967 into nodejs:main Apr 20, 2026
6 checks passed
@dario-piotrowicz
dario-piotrowicz deleted the dario/add-missing-en-to-download-navigation branch April 20, 2026 13:49
@ovflowd

ovflowd commented Apr 20, 2026

Copy link
Copy Markdown
Member

FYI @nodejs/web-infra I know we merged this but this isn't a proper fix... Imagine you are:

  • Some page on /fr of our website
  • Click Learn
  • Then Click Downloads...

It will just go back to wrong language. Ill make a proper fix upstream soon.

@MattIPv4

Copy link
Copy Markdown
Member

Ill make a proper fix upstream soon.

What do you plan for that fix to be? Learn isn't localized, and /download is a special route that needs to go to the worker so cannot be a Next.js i18n redirect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants