Skip to content

fix(git-node): fix SSH passphrase input when promoting a release #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(git-node): fix SSH passphrase input when promoting a release #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/promote_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { pipeline } from 'node:stream/promises';
import semver from 'semver';
import * as gst from 'git-secure-tag';

import { forceRunAsync } from './run.js';
import { forceRunAsync, runSync } from './run.js';
import PRData from './pr_data.js';
import PRChecker from './pr_checker.js';
import Session from './session.js';
Expand Down Expand Up @@ -59,7 +59,8 @@ export default class ReleasePromotion extends Session {
if (!localCloneIsClean) {
if (await cli.prompt('Should we checkout the release proposal?')) {
cli.startSpinner('Fetching the proposal upstream...');
await forceRunAsync('git', ['fetch', proposalUpstreamRemote, releaseCommitSha],
// We need a sync spawn here to avoid the spinner getting in the way of SSH key passphrase
runSync('git', ['fetch', proposalUpstreamRemote, releaseCommitSha],
{ ignoreFailure: false });
await forceRunAsync('git', ['checkout', releaseCommitSha], { ignoreFailure: false });
cli.stopSpinner('Local HEAD is now in sync with the proposal');
Expand Down
Loading