chore!: remove npm shrinkwrap, bundle package dependencies - #1135
Open
Renegade334 wants to merge 1 commit into
Open
chore!: remove npm shrinkwrap, bundle package dependencies#1135Renegade334 wants to merge 1 commit into
Renegade334 wants to merge 1 commit into
Conversation
npm-shrinkwrap.json previously ensured that a consumer installing the NCU package would also install the exact dependency versions from npm-shrinkwrap.json. This npm feature is being withdrawn. To avoid exposing NCU consumers to supply chain issues in transitive dependencies, we now bundle a copy of our "locked" dependency tree in the package that is published to npm.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
=======================================
Coverage 57.32% 57.32%
=======================================
Files 53 53
Lines 10368 10368
=======================================
Hits 5943 5943
Misses 4425 4425 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1121.
"Locks" the full dependency tree for consumers by bundling the dependencies (as constrained by our own package-lock.json) with the published package.
The size of the @node-core/utils package goes from
to
although the dependencies that are now bundled would previously have to be resolved and installed by npm anyway.
The main differences from shrinkwrap:
npm packgoes into an infinite resolution loop if a bundled dependency is overridden by anoverridesentry, which we were relying upon until recently (984125a). I'll report upstream, but for the time being, we wouldn't be able to call upon this feature if needed.