tls: move _tls_* to end-of-life #60658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
Author
|
cc: @nodejs/tsc since it’s an end-of-life deprecation |
bjohansebas
added
semver-major
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60658 +/- ##
==========================================
- Coverage 89.78% 88.90% -0.88%
==========================================
Files 672 670 -2
Lines 203809 203786 -23
Branches 39183 39096 -87
==========================================
- Hits 182980 181182 -1798
- Misses 13166 14874 +1708
- Partials 7663 7730 +67
🚀 New features to boost your workflow:
|
AugustinMauroy
approved these changes
Nov 10, 2025
Member
Author
|
cc @nodejs/crypto @nodejs/net |
pimterry
approved these changes
Dec 19, 2025
aduh95
added
the
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
RafaelGSS
approved these changes
Dec 26, 2025
Member
Author
|
It looks flaky in GitHub Actions CI. Could someone rerun it, please? |
Member
Author
|
Should I do a rebase to see if it’s still failing? |
Contributor
That wouldn't help (unless a fix for the flakiness had landed on main since last commit, but AFAIK that's not the case), and force us to re-review and re-run all CI jobs |
bjohansebas
added
needs-citgm
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60658 ✔ Done loading data for nodejs/node/pull/60658 ----------------------------------- PR info ------------------------------------ Title tls: move _tls_* to end-of-life (#60658) Author Sebastian Beltran <bjohansebas@gmail.com> (@bjohansebas) Branch bjohansebas:tls_eol -> nodejs:main Labels tls, c++, semver-major, author ready, deprecations, needs-ci, needs-citgm Commits 1 - tls: move _tls_* to end-of-life Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Nov 2025 21:40:41 GMT ✔ Approvals: 2 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/60658#pullrequestreview-3597808519 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-3613841924 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-12-20T16:15:00Z: https://ci.nodejs.org/job/node-test-pull-request/70556/ - Querying data for job/node-test-pull-request/70556/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21187285768 |
Ethan-Arrowood
approved these changes
Jan 22, 2026
RafaelGSS
approved these changes
Jan 26, 2026
RafaelGSS
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
Note that these weren't runtime-deprecated in 24, only in 25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.