Skip to content

readline: initialize input before history manager #61538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zohaibarif69 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

readline: initialize input before history manager #61538

Zohaibarif69 wants to merge 1 commit into from
+23 −5

Conversation

@Zohaibarif69
Copy link

@Zohaibarif69 Zohaibarif69 commented Jan 27, 2026

Fixes a regression where setupHistoryManager() could run before
this.input was assigned, causing a crash when onHistoryFileLoaded
is present (for example, Proxy or jest.mock() inputs).

This change ensures this.input is initialized before history setup
and adds a regression test to cover the scenario.

Refs: #61526

Testing:

  • Added regression test
  • Unable to run tests locally due to Windows build issues; CI should validate

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zohaibarif69 @nodejs-github-bot