-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
diagnostics_channel: add WindowChannel and scopes #61680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds support for using scope = storage.withScope(data) to do the equivalent of a storage.run(data, fn) with using syntax. This enables avoiding unnecessary closures.
|
Review requested:
|
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/21678728231 |
302c219 to
c764f06
Compare
This adds WindowChannel, adds using scope support to runStores, and modifies the internals to use these to avoid closures in several places.
RafaelGSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please expand on PR description on why this is needed? We have channels, tracingChannels and now windowChannel, it would be great to know for which kind of situations we need each one of them.
| added: REPLACEME | ||
| --> | ||
|
|
||
| > Stability: 1 - Experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > Stability: 1 - Experimental | |
| > Stability: 1 - Experimental |
Perhaps 1.1 Active Development instead?
|
It's also replacing most of the internals of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61680 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.01%
==========================================
Files 674 675 +1
Lines 204389 204607 +218
Branches 39280 39291 +11
==========================================
+ Hits 183424 183607 +183
- Misses 13264 13293 +29
- Partials 7701 7707 +6
🚀 New features to boost your workflow:
|
This adds
WindowChannel, adds ausingsyntax equivalent torunStores, and modifies the internals to use these to avoid closures in several places.Depends on #61674
cc @nodejs/diagnostics