deps: V8: cherry-pick 64b36b441179#61698
Open
rmagrin wants to merge 1 commit intonodejs:v24.x-stagingfrom
Open
deps: V8: cherry-pick 64b36b441179#61698rmagrin wants to merge 1 commit intonodejs:v24.x-stagingfrom
rmagrin wants to merge 1 commit intonodejs:v24.x-stagingfrom
Conversation
Original commit message:
optimize ascii fast path in WriteUtf8V2
Change-Id: If28168cb4395b953d0ec642ef4fc618ce963dbcd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7124103
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Erik Corry <erikcorry@chromium.org>
Reviewed-by: Erik Corry <erikcorry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103542}
Refs: v8/v8@64b36b4
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Author
|
@nodejs-github-bot v8-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteUtf8V2)simdutf::validate_asciimemcpyfor pure-ASCII strings instead of byte-by-byte UTF-8 encodingv8_embedder_stringfrom-node.40to-node.41Changes
Files modified:
deps/v8/src/strings/unicode-inl.h— AddedIsAsciiOneByteStringtemplate specializations and ASCII fast path inEncodedeps/v8/src/strings/unicode.h— AddedIsAsciiOneByteStringdeclarationscommon.gypi— Incremented embedder stringNote on Manual Fix
The cherry-pick required a manual addition of
#include "third_party/simdutf/simdutf.h"tounicode-inl.h. The upstream V8 commit relies on this include being present, but the git-node backport tool did not pick it up (the include may have been added in a separate commit or already present in newer V8 versions).References
Test Plan
make cctest— 176/176 tests passedpython3 tools/test.py -J --mode=release v8— 25/25 tests passedpython3 tools/test.py -J --mode=release— 4795/4796 tests passed (1 unrelated SEA test failure)