test: make snapshot path matching CWD-agnostic#61846
Open
drtootsie wants to merge 2 commits intonodejs:mainfrom
Open
test: make snapshot path matching CWD-agnostic#61846drtootsie wants to merge 2 commits intonodejs:mainfrom
drtootsie wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
reviewed
Feb 16, 2026
lib/internal/test_runner/coverage.js
Outdated
| if (range.count !== 0 || | ||
| range.ignoredLines === range.lines.length) { | ||
| branchesCovered++; | ||
| // Skip branches that are entirely on ignored lines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61846 +/- ##
==========================================
- Coverage 89.78% 89.65% -0.13%
==========================================
Files 674 676 +2
Lines 204957 206240 +1283
Branches 39391 39506 +115
==========================================
+ Hits 184011 184902 +891
- Misses 13214 13466 +252
- Partials 7732 7872 +140 🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Feb 16, 2026
cjihrig
requested changes
Feb 16, 2026
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
Can you separate out the unrelated changes please.
Fixes: nodejs#61303 The snapshot path transformation was incorrectly matching partial paths like '/node' within '/node_modules' or 'nodejs.org', causing false replacements. Added negative lookahead (?![\w/]) to the regex patterns to ensure only complete path segments are matched, preventing partial matches in directory names and URLs.
drtootsie
force-pushed
the
fix-cwd-agnostic-snapshot-tests
branch
from
f95913e to
975d553
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #61303
Summary
The snapshot path transformation was incorrectly matching partial paths like
/nodewithin/node_modulesornodejs.org, causing false replacements.Changes
Added negative lookahead
(?![\\w/])to the regex patterns intest/common/assertSnapshot.jsto ensure only complete path segments are matched.This prevents partial matches in:
/node_modules)nodejs.org)Testing
Requires building Node.js and running the test suite:
./configure && make -j4 make test-only