crypto: rename CShakeParams and KmacParams length to outputLength#61875
Open
panva wants to merge 1 commit intonodejs:mainfrom
Open
crypto: rename CShakeParams and KmacParams length to outputLength#61875panva wants to merge 1 commit intonodejs:mainfrom
panva wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
ca4ab2f to
95843e5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61875 +/- ##
==========================================
- Coverage 89.70% 89.65% -0.06%
==========================================
Files 676 676
Lines 206069 206240 +171
Branches 39520 39506 -14
==========================================
+ Hits 184860 184907 +47
- Misses 13358 13461 +103
- Partials 7851 7872 +21
🚀 New features to boost your workflow:
|
Member
Author
|
ping @nodejs/crypto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the implementation of
CShakeParamsandKmacParamsdictionaries with a change made in https://redirect.github.com/WICG/webcrypto-modern-algos/pull/52Documentation diff is due to keeping the attributes in a dictionary order.
Note that these are both experimentalIssues and PRs related to experimental features.
.