Skip to content

crypto: rename CShakeParams and KmacParams length to outputLength#61875

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:modern-updates
Open

crypto: rename CShakeParams and KmacParams length to outputLength#61875
panva wants to merge 1 commit intonodejs:mainfrom
panva:modern-updates

Conversation

@panva
Copy link
Member

@panva panva commented Feb 18, 2026

Aligns the implementation of CShakeParams and KmacParams dictionaries with a change made in https://redirect.github.com/WICG/webcrypto-modern-algos/pull/52

Documentation diff is due to keeping the attributes in a dictionary order.

Note that these are both experimental Issues and PRs related to experimental features. .

@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto labels Feb 18, 2026
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 18, 2026
@panva panva marked this pull request as ready for review February 18, 2026 11:22
@panva panva added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lts-watch-v24.x PRs that may need to be released in v24.x labels Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.65%. Comparing base (7cf2dad) to head (90a0c4c).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/webidl.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61875      +/-   ##
==========================================
- Coverage   89.70%   89.65%   -0.06%     
==========================================
  Files         676      676              
  Lines      206069   206240     +171     
  Branches    39520    39506      -14     
==========================================
+ Hits       184860   184907      +47     
- Misses      13358    13461     +103     
- Partials     7851     7872      +21     
Files with missing lines Coverage Δ
lib/internal/crypto/hash.js 98.93% <100.00%> (ø)
lib/internal/crypto/mac.js 91.12% <100.00%> (ø)
lib/internal/crypto/webidl.js 98.33% <75.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva changed the title crypto: rename cSHAKEParams and KmacParams length to outputLength crypto: rename CSHAKEParams and KmacParams length to outputLength Feb 18, 2026
@panva panva changed the title crypto: rename CSHAKEParams and KmacParams length to outputLength crypto: rename CShakeParams and KmacParams length to outputLength Feb 18, 2026
@panva panva added the review wanted PRs that need reviews. label Feb 23, 2026
@panva
Copy link
Member Author

panva commented Mar 1, 2026

ping @nodejs/crypto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. experimental Issues and PRs related to experimental features. lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run. review wanted PRs that need reviews. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants