Skip to content

doc: update DEP0040 (punycode) to application type deprecation#61916

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
MikeMcC399:dep0040-application-type-deprecation
Feb 28, 2026
Merged

doc: update DEP0040 (punycode) to application type deprecation#61916
nodejs-github-bot merged 2 commits intonodejs:mainfrom
MikeMcC399:dep0040-application-type-deprecation

Conversation

@MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 21, 2026

Refs: #61901 (comment)

Situation

DEP0040: node:punycode module is listed as Runtime deprecation since v21.0.0.

This is missing the change applied by PR #56632 to v23.7.0, backported also to v22.14.0, which changed to Application deprecation (non-node_modules code only).

Change

Update DEP0040 to

Type: Application (non-node_modules code only)

with History change in

through PR #56632

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Feb 21, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 21, 2026 09:31
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
@MikeMcC399
Copy link
Contributor Author

Preview

image

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2026
@Renegade334 Renegade334 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Feb 26, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 26, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61916
✔  Done loading data for nodejs/node/pull/61916
----------------------------------- PR info ------------------------------------
Title      doc: update DEP0040 (punycode) to application type deprecation (#61916)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MikeMcC399:dep0040-application-type-deprecation -> nodejs:main
Labels     doc, author ready, deprecations, dont-land-on-v20.x
Commits    2
 - doc: update DEP0040 (punycode) to application type deprecation
 - add text "(non-`node_modules` code only)"
Committers 2
 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61916
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61916
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 21 Feb 2026 09:30:32 GMT
   ✔  Approvals: 1
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61916#pullrequestreview-3835438006
   ✘  This PR needs to wait 34 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/22466215223

@Renegade334 Renegade334 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 26, 2026
@MikeMcC399

This comment was marked as resolved.

@Renegade334 Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 28, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61916
✔  Done loading data for nodejs/node/pull/61916
----------------------------------- PR info ------------------------------------
Title      doc: update DEP0040 (punycode) to application type deprecation (#61916)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MikeMcC399:dep0040-application-type-deprecation -> nodejs:main
Labels     doc, author ready, deprecations, dont-land-on-v20.x
Commits    2
 - doc: update DEP0040 (punycode) to application type deprecation
 - add text "(non-`node_modules` code only)"
Committers 2
 - Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/61916
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61916
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 21 Feb 2026 09:30:32 GMT
   ✔  Approvals: 1
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/61916#pullrequestreview-3835438006
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 61916
From https://github.com/nodejs/node
 * branch                  refs/pull/61916/merge -> FETCH_HEAD
✔  Fetched commits as 6a3d358ca411..ce48528947e8
--------------------------------------------------------------------------------
Auto-merging doc/api/deprecations.md
[main 847a63a66e] doc: update DEP0040 (punycode) to application type deprecation
 Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
 Date: Sat Feb 21 10:23:32 2026 +0100
 1 file changed, 6 insertions(+), 1 deletion(-)
Auto-merging doc/api/deprecations.md
[main 92bffd52f4] add text "(non-`node_modules` code only)"
 Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
 Date: Sat Feb 21 10:46:14 2026 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:400) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update DEP0040 (punycode) to application type deprecation

PR-URL: #61916
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

[detached HEAD 9a1f0d9646] doc: update DEP0040 (punycode) to application type deprecation
Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Date: Sat Feb 21 10:23:32 2026 +0100
1 file changed, 6 insertions(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
add text "(non-node_modules code only)"

Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
PR-URL: #61916
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

[detached HEAD 2628983723] add text "(non-node_modules code only)"
Author: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Date: Sat Feb 21 10:46:14 2026 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/22520448302

@Renegade334 Renegade334 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 28, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2026
@nodejs-github-bot nodejs-github-bot merged commit 27261b9 into nodejs:main Feb 28, 2026
47 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 27261b9

@MikeMcC399 MikeMcC399 deleted the dep0040-application-type-deprecation branch February 28, 2026 12:36
@MikeMcC399
Copy link
Contributor Author

Thanks for your perseverance @Renegade334 ! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants